[PATCH] D80683: [SelectionDAG] Fix up SimplifyDemandedBits for ppcf128
    Simon Pilgrim via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu May 28 02:08:12 PDT 2020
    
    
  
RKSimon added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:852
+  if (VT == MVT::ppcf128 && TLO.DAG.getDataLayout().isLittleEndian())
+    DemandedBits = DemandedBits.rotl(64);
+
----------------
Won't this rotate the bits every time you recursively call the function? You might need to limit this to Depth == 0 and then handle/bailout in the ISD::BITCAST case below.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80683/new/
https://reviews.llvm.org/D80683
    
    
More information about the llvm-commits
mailing list