[PATCH] D80611: [BrachProbablityInfo] Proportional distribution of reachable probabilities

[Yevgeny Rouban via Phabricator via llvm-commits]

yrouban marked 5 inline comments as done.
yrouban added inline comments.


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:385
+  BranchProbability NewUnreachableSum = BranchProbability::getZero();
+  for (auto i : UnreachableIdxs)
+    NewUnreachableSum += BP[i];
----------------
yamauchi wrote:
> Capitalize 'i' -> 'I'.
> 
> This loop could be combined with the above loop, but would be less clear?
The old code above has the index //i// lowcased. I would propose to keep the style.
Yes, the separate loop is for clarity.



================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:392
+  BranchProbability OldReachableSum = BranchProbability::getZero();
+  for (auto i : ReachableIdxs)
+    OldReachableSum += BP[i];
----------------
yamauchi wrote:
> Capitalize 'i' -> 'I'
ditto, if you do not insist


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80611/new/

https://reviews.llvm.org/D80611