[PATCH] D80613: Getting R_X86_64_PC32 working as our first relocation

[Jared Wyles via Phabricator via llvm-commits]

jaredwy added a comment.

Clang-format was run but doesn't seem to catch this case, ill clean it up later this afternoon.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:237
+        }
+        // TODO error handling?
+        auto BlockToFix = *JITSection->blocks().begin();
----------------
lhames wrote:
> For what error condition? Empty sections? Does your parser ever produce them?
No. If a JITSection is found, it would be next to impossible not to have a block. So if i push the error check on jitSection that should ensure a block is present 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80613/new/

https://reviews.llvm.org/D80613