[PATCH] D80208: [CodeGen] Add support for extracting elements of scalable vectors

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17433
   // extract_vector_elt (build_vector x, y), 1 -> y
-  if (IndexC && VecOp.getOpcode() == ISD::BUILD_VECTOR &&
+  if (IndexC &&
+      (VecOp.getOpcode() == ISD::BUILD_VECTOR ||
----------------
Should this be `if ((VecOp.getOpcode() == ISD::SPLAT_VECTOR || (IndexC && VecOp.getOpcode() == ISD::BUILD_VECTOR) && [...])`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80208/new/

https://reviews.llvm.org/D80208