[PATCH] D80667: [mlir] Use ValueRange instead of ArrayRef<Value> in adaptor

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar created this revision.
jpienaar added reviewers: mehdi_amini, silvas.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, bader, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddle.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: antiagainst.
Herald added a reviewer: ftynse.
Herald added a project: LLVM.

This allows constructing an operand adaptor from existing op (useful for commonalizing verification as I want to do in a follow up). ValueRange also allows the same code to be used in more instances.

I also addied the ability to use member initializers for the generated adaptor constructors for convenience. It was required for a different version of this but not essential for this one (just matches closer to how one would write the code that is being generated) so I could split it out.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80667

Files:
  mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
  mlir/include/mlir/Dialect/SPIRV/SPIRVLowering.h
  mlir/include/mlir/TableGen/OpClass.h
  mlir/include/mlir/TableGen/Operator.h
  mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
  mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
  mlir/lib/TableGen/OpClass.cpp
  mlir/lib/TableGen/Operator.cpp
  mlir/test/mlir-tblgen/op-decl.td
  mlir/test/mlir-tblgen/op-operand.td
  mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80667.266674.patch
Type: text/x-patch
Size: 17117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200527/9c6607b7/attachment.bin>