[PATCH] D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic.

[Wen-Heng (Jack) Chung via Phabricator via llvm-commits]

whchung marked 2 inline comments as done.
whchung added inline comments.


================
Comment at: mlir/include/mlir/Conversion/GPUCommon/GPUCommonPass.h:12
 #include "mlir/Support/LLVM.h"
+#include "llvm/IR/Module.h"
 #include <functional>
----------------
rriddle wrote:
> Is this header really necessary?
@rriddle it's necessary so `llvm::Module` is visible. Forward declaration is not possible because `sizeof(llvm::Module)` would be used in one of the unit test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80142/new/

https://reviews.llvm.org/D80142