[PATCH] D80321: [mlir][spirv] Enable composite instructions for cooperative matrix type.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 14:10:18 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVOps.cpp:1138
+  } else {
+    if (constituents.size() != cType.getNumElements())
+      return compositeConstructOp.emitError(
----------------
nit: Merge this if into the else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80321/new/

https://reviews.llvm.org/D80321





More information about the llvm-commits mailing list