[PATCH] D80270: [mlir][spirv] Adapt subview legalization to the updated op semantics.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:2559
+          return getOperand(dynamicIdx++);
+        else
+          return b.create<ConstantIndexOp>(loc, staticOffset);
----------------
nit: Don't use else after a return.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:2571
+          return getOperand(dynamicIdx++);
+        else
+          return b.create<ConstantIndexOp>(loc, staticSize);
----------------
Same here and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80270/new/

https://reviews.llvm.org/D80270