[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1521
       emitLinkage(&F, Name);
+      continue;
     }
----------------
jasonliu wrote:
> ```
> if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) {
>   ...
>   emitLinkage()
> } else {
>   ...
>   emitVisibility()
> }
> ```
> 
> Might be a better choice than "continue" here. If F is an intrinsic then it would go to "emitVisibility" block even if it's XCOFF target. It may or may not do any harm, but I think it would be better not go to there.
> 
Sorry, I think this might be better.

```
if (TM.getTargetTriple().isOSBinFormatXCOFF())
  if (!F.isIntrinsic())
    continue;
  ...
  emitLinkage()
} else {
  ...
  emitVisibility()
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866