[PATCH] D79184: [MLIR][LoopOps] Adds the loop unroll transformation for loop::ForOp.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 13:36:24 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/test/lib/Transforms/TestLoopUnrolling.cpp:23
+
+static unsigned getNestingDepth(Operation *op) {
+  Operation *currOp = op;
----------------
nit: Static functions go in the top-level namespace.


================
Comment at: mlir/test/lib/Transforms/TestLoopUnrolling.cpp:51
+    });
+    for (auto loop : loops) {
+      loopUnrollByFactor(loop, unrollFactor);
----------------
nit: Drop trivial braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79184/new/

https://reviews.llvm.org/D79184





More information about the llvm-commits mailing list