[PATCH] D79922: [MLIR] Allow unreachable blocks to violate dominance property.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/IR/Dominance.cpp:186
+  if (baseInfoIt == dominanceInfos.end())
+    return true;
+  return baseInfoIt->second->isReachableFromEntry(a);
----------------
rriddle wrote:
> Is there a reason we assume unknown blocks are reachable?
(Not that I disagree with your choice here, just checking if you thought about it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79922/new/

https://reviews.llvm.org/D79922