[PATCH] D77524: [TargetPassConfig] Add CanonicalizeFreezeInLoops before LSR

Wed May 27 13:03:16 PDT 2020

aqjune added reviewers: nikic, reames, xbolva00.
aqjune added a comment.

ping

I evaluated the performance impact on linking time by compiling CTMark with -O3 + LTO enabled, and the result was as follows:

  (unit: sec.)
  			bed7884	+D77524	speedup
  7zip			47.34	47.29	0.12%
  bullet			9.83	9.62	2.28%
  clamscan		25.42	25.44	-0.06%
  SPASS			19.91	19.93	-0.12%
  consumer-typeset	19.12	19.24	-0.64%
  kimwitu++		15.19	15.06	0.88%
  lencod			39.91	40.03	-0.30%
  mafft			8.77	8.77	0.05%
  sqlite3			25.07	25.33	-1.02%
  tramp3d-v4		36.23	36.21	0.06%

The geometric mean of speedup is -0.13%, which seems to be within an error, considering that compilation time (without linking time) showed 0.1% average speedup which should be 0% in theory because LTO is enabled.

As the validity of this patch has been discussed at D77523 <https://reviews.llvm.org/D77523>, I think it is okay to add the pass before LSR.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77524/new/

https://reviews.llvm.org/D77524