[PATCH] D79841: [MLIR] refactor cmake specification of tablegen'd interfaces.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.
Herald added a subscriber: jurahul.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:17
 
+# Declare a dialect in the include directory
+function(add_mlir_interface interface)
----------------
This comment seems wrong.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:18
+# Declare a dialect in the include directory
+function(add_mlir_interface interface)
+  set(LLVM_TARGET_DEFINITIONS ${interface}.td)
----------------
nit: I would have named this add_mlir_op_interface just in case we somehow auto-gen dialect interfaces in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79841/new/

https://reviews.llvm.org/D79841