[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 12:29:47 PDT 2020
jyknight added a comment.
> The current state doesn't appear to block it or prevent it in any way
It does prevent it. This change introduces an argument, -T to the option syntax of the llvm-strip tool, which we'd be better off without. But, once we add it, users of llvm-strip will depend on it, and then we can't easily remove it later on. The only argument for the name -T is compatibility with cctools strip, which is unachievable within a single driver syntax, anyways.
Now, if it wasn't for all the other incompatibilities with cctools' strip, I could buy the argument that it's worth adding -T, despite that it was a bad choice of name, and despite the potential for future conflicts. But, since compatibility is impossible, we have those downsides, and little upside to go along with it.
> introducing a new name would break the existing use-cases
I don't see how, since llvm-strip isn't a drop in replacement for cctools strip anyhow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80099/new/
https://reviews.llvm.org/D80099
More information about the llvm-commits
mailing list