[PATCH] D79640: Add Operation::moveAfter
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 12:29:46 PDT 2020
rriddle added a comment.
Herald added a subscriber: jurahul.
In D79640#2027782 <https://reviews.llvm.org/D79640#2027782>, @GMNGeoffrey wrote:
> Pardon my phabricator ignorance, but why is the comment here "This revision was not accepted when it landed; it landed in state Needs Review" immediately below "mehdi_amini accepted this revision"? Is that because River is marked as a blocking reviewer? Seems like a fragile system to have one person be the only one who can approve some set of code. What if they go on vacation?
In general if you are touching something and the code owner is on vacation you wait for them to get back. Whether you care about getting a proper review from the code owner or not is up to you morally. If you don't care and there is a proper alternative reviewer, then you don't necessarily have to wait, but to each their own...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79640/new/
https://reviews.llvm.org/D79640
More information about the llvm-commits
mailing list