[PATCH] D80634: [SVE] Fix warnings in SelectInst::areInvalidOperands
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 12:29:41 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/IR/Instructions.cpp:84
return "selected values for vector select must be vectors";
- if (ET->getNumElements() != VT->getNumElements())
+ if (ET->getElementCount() != VT->getElementCount())
return "vector select requires selected vectors to have "
----------------
We probably want a testcase to make sure we don't accept `select <2 x i1> zeroinitializer, <vscale x 2 x i64> zeroinitializer, <vscale x 2 x i64> zeroinitializer`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80634/new/
https://reviews.llvm.org/D80634
More information about the llvm-commits
mailing list