[PATCH] D80185: [xray] Add llvm-xray extract support for 32 bit ARM
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 11:56:34 PDT 2020
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LG, but please remove unneeded re-formatting in this patch.
================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:100
+ else if (const auto *ELFObj =
+ dyn_cast<object::ELF32BEObjectFile>(ObjFile))
return ELFObj->getELFFile()->getRelativeRelocationType();
----------------
This re-formatting is not needed.
================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:263
+ Expected<sys::fs::file_t> FdOrErr =
+ sys::fs::openNativeFileForRead(Filename);
if (!FdOrErr) {
----------------
The formatting is not needed.
You can ignore clang-format diagnostic for existing problems.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80185/new/
https://reviews.llvm.org/D80185
More information about the llvm-commits
mailing list