[PATCH] D60390: FileCheck [10/12]: Add support for signed numeric values
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 11:23:22 PDT 2020
thopre marked an inline comment as done.
thopre added inline comments.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:422
+ // Test both negative values.
+ expectOperationValueResult(operator+, - 10, - 10, - 20);
+
----------------
jhenderson wrote:
> Here and in various other places, not sure you want the space between `-` and `10` (same for `- 20` and various cases below).
I don't like it either but this comes from clang-format-diff.py. Should I go against it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60390/new/
https://reviews.llvm.org/D60390
More information about the llvm-commits
mailing list