[PATCH] D80608: [llvm-mc] Make the suffix matcher more accurate.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3474
     Tmp.back() = Suffixes[I];
-    Match[I] = MatchInstruction(Operands, Inst, ErrorInfoIgnore,
-                                MissingFeatures, MatchingInlineAsm,
-                                isParsingIntelSyntax());
-    // If this returned as a missing feature failure, remember that.
-    if (Match[I] == Match_MissingFeature)
-      ErrorInfoMissingFeatures = MissingFeatures;
+    if (MemOp)
+      MemOp->Mem.Size = MemSize[I];
----------------
This breaks assembling of `movzb  1280(%rbx,%r12), %r12` (`!HasVectorReg`)

I fixed it in 5b4cd2d4c42360469ccc9f59aa04a1a24b290df9 . There may be further clean-ups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80608/new/

https://reviews.llvm.org/D80608