[PATCH] D80511: [llvm-objcopy][ELF] Fix removing ".group" sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 08:06:36 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/remove-section-group.test:29
+
+# CHECK:        Section {
+# CHECK:          Name: .foo
----------------
jhenderson wrote:
> Up to you, but you can probably also delete this line too, as you are only dumping sections.
Move `CHECK:` before the YAML text as people seem to think the following order

```
RUN:
CHECK:
source
```

is easier to read.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80511/new/

https://reviews.llvm.org/D80511





More information about the llvm-commits mailing list