[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

We already _aren't_ and _cannot_ be compatible with cctools strip's command-line, because cctools strip already has a bunch of one-letter option choices which actively conflict with existing options in llvm-strip (and GNU strip from which we copied them). There's at least -s -R -d -N with conflicting meanings.

Given that, I do not think adding "-T" to llvm-strip is good idea. While it may not conflict today, it might tomorrow. With command-line compatibility to cctools out of the question, it then comes down to a question of naming -- and "-T" is just a bad choice for a special-purpose option like this. It ought to have been given a descriptive option name in the first place.

I do think we should just rename this to --strip-swift-symbols for llvm-strip. If, in the future, someone wants to make another command which is a drop-in-replacement for cctools strip, that could be done, and it will need to do option-translation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80099/new/

https://reviews.llvm.org/D80099