[PATCH] D80619: [UnJ] Update LI for inner nested loops

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 05:22:12 PDT 2020


Whitney added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/innerloop.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -loop-unroll-and-jam -allow-unroll-and-jam -unroll-and-jam-count=4 < %s -S | FileCheck %s
----------------
nit: remove this line as the checks don't look like autogenerated by utils/update_test_checks.py.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/innerloop.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -loop-unroll-and-jam -allow-unroll-and-jam -unroll-and-jam-count=4 < %s -S | FileCheck %s
+
----------------
Add a run line for new pass manager.
No need `-unroll-and-jam-count=4 ` as there exists metadata which indicate to unroll and jam the middle loop by 4.
Suggest to add `-verify-loop-info` or `-passes='verify<loops>'` to explicitly test the loop info is correct after unroll and jam.

Example:
```
; RUN: opt -basicaa -tbaa -loop-unroll-and-jam -allow-unroll-and-jam -verify-loop-info < %s -S | FileCheck %s
; RUN: opt -aa-pipeline=type-based-aa,basic-aa -passes='unroll-and-jam,verify<loops>' -allow-unroll-and-jam < %s -S | FileCheck %s
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80619/new/

https://reviews.llvm.org/D80619





More information about the llvm-commits mailing list