[PATCH] D80476: [DebugInfo/llvm-objdump] - Print "ZERO terminator" for terminator entries when dumping .eh_frame.

Wed May 27 02:39:57 PDT 2020

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:307
 void CIE::dump(raw_ostream &OS, const MCRegisterInfo *MRI, bool IsEH) const {
+  // A CIE with a zero length is a terminator entry in the .eh_frame sextion.
+  if (IsEH && Length == 0) {
----------------
jhenderson wrote:
> MaskRay wrote:
> > typo: section
> Looks like this typo was never fixed?
Right, sorry. Fixed in https://github.com/llvm/llvm-project/commit/84c643358691b8057199e8c8597428ad0d960786. Thanks for catching!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80476/new/

https://reviews.llvm.org/D80476