[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[David Truby via Phabricator via llvm-commits]

DavidTruby added a comment.

> Is there reason to believe that a subset of asserts/unreachable that would be always-on would improve Clang significantly, for instance? If not, then I don't think flang should be making a different tack here.

+1 on this. Clang is a tried and tested compiler that many people are already shipping downstream commercial compilers based on. 
If there's a significant problem with how it does error handling it should be discussed there as well as here and fixed for both. 
If not, we should do the same thing as clang does here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507