[PATCH] D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description

Wed May 27 01:02:42 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit and a suggestion. Please wait for somebody else to confirm too.

================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:27
+  // address.
+  EXPECT_LT(SIT1, SIT2);
+  EXPECT_FALSE(SIT2 < SIT1);
----------------
Up to you, but it might be good to switch these EXPECT_LT lines for the more explicit `EXPECT_TRUE(SIT1 < SIT2);` for consistency with the `EXPECT_FALSE` checks. I'm happy either way though.

================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:44
+
+  // Test symbols compare with itself.
+  EXPECT_FALSE(SIT1 < SIT1);
----------------
compare with itself. -> comparing with themselves.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78387/new/

https://reviews.llvm.org/D78387