[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

Tue May 26 23:57:41 PDT 2020

sscalpone added a comment.

In D79507#2055540 <https://reviews.llvm.org/D79507#2055540>, @DavidTruby wrote:

> > Anyway, why not modify DIE by appending llvm_unreachable after the call to Fortran::common::die?
>
> This was originally the approach taken by Kiran from AMD in this patch: https://github.com/flang-compiler/f18/pull/1057
>  It was rejected pending the aforementioned discussion about doing things the way LLVM does them currently vs changing the LLVM policy.

That doesn't seem to be the case.  Quoting:

> ...that there is no benefit of partially replacing die function with llvm_unreachable. I will go ahead and close this PR.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507