[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 21:14:19 PDT 2020


MaskRay added a comment.

In D80099#2056447 <https://reviews.llvm.org/D80099#2056447>, @jyknight wrote:

> Isn't this potentially problematic from a compatibility point-of-view, since it squats a single-letter command-line argument for a mach-o-specific feature, while llvm-strip is generally trying to be compatible to GNU strip?


I think it may be problematic if GNU strip reserves -T for other purposes. Can we have a `--strip-*` long option instead? `--strip_swift_symbols` (the obvious option name inferred from the TableGen variable) may not be most suitable because from the description "_$S' or _$s' only if it finds an __objc_image_info section containin" this option only strips some special cased symbols, not all Swift symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80099/new/

https://reviews.llvm.org/D80099





More information about the llvm-commits mailing list