[PATCH] D79969: [LAA] We only need pointer checks if there are non-zero checks (NFC).
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 14:45:03 PDT 2020
Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.
Looks good to me. Added a minor nit.
================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:820
+ // object for example.
+ RtCheck.Need = CanDoRT ? RtCheck.getNumberOfChecks() != 0 : NeedRTCheck;
----------------
Sounds a bit confusing to continue having both `RtCheck.Need` and `NeedRTCheck`, where the former no longer simply caches the value of the latter. Could one be more accurately renamed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79969/new/
https://reviews.llvm.org/D79969
More information about the llvm-commits
mailing list