[PATCH] D79100: [LV][TTI] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 14:11:17 PDT 2020
SjoerdMeijer added a comment.
Many thanks for taking a look Florian!
> I think introducing a VPInstruction opcode for the new intrinsic makes sense and fits in the current scheme. But I think there's no need to bundle the langref, TTI and LV changes into a single patch. IMO would be good to split at least the LV part off, to focus on discussing the implementation details in LV there
Ok, but Just double checking that I get this right:
- In the LV part, we do use and check TTI.emitGetActiveLaneMask, so I guess that means we have LV + TTI in one patch,
- and separate we have LangRef.
That looks like a minimal change, but certainly don't mind doing this if that helps.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79100/new/
https://reviews.llvm.org/D79100
More information about the llvm-commits
mailing list