[PATCH] D80544: [LoopUnroll] Simplify latch/header block handling (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:719
 
   auto setDest = [LoopExit, ContinueOnTrue](BasicBlock *Src, BasicBlock *Dest,
                                             BasicBlock *BlockInLoop,
----------------
efriedma wrote:
> While you're here, can you change this so the "LoopExit" and "ContinueOnTrue" are passed in as arguments?  I think changing the meaning based on LatchIsExiting is confusing.
Done thanks. I've turned LoopExit into a bool (IsDestLoopExit). That should make the fact it is always false for the header case more explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80544/new/

https://reviews.llvm.org/D80544