[PATCH] D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 13:05:43 PDT 2020


efriedma added a comment.

In terms of optimization, the primary benefit would just be that you're doing smaller memcpys at the same place you're using the values; that simplifies alias analysis, and smaller memcpys are more likely to optimize the way you want.

In terms of actually writing code, of course, the biggest benefit is that it just works; once you've defined the struct with the right types, you never have to think about alignment/endianness again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80414/new/

https://reviews.llvm.org/D80414





More information about the llvm-commits mailing list