[PATCH] D79832: Initial commit for the elf x86 implementation for jitlink

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:100
+        Value = SymRef.getValue();
+        LLVM_DEBUG({
+          dbgs() << "  ";
----------------
abhinavgaba wrote:
> `Binding` and `Value` are read only inside this `LLVM_DEBUG`, making them unread if debug messages are disabled.
> 
>   error: variable ‘Binding’ set but not used [-Werror=unused-but-set-variable]
Usually easier to commit fixes for things like this directly, rather than going through a round of feedback, waiting for someone to fix, etc.

I've fixed this in fca76b79456c916fd2ce193ef76d6e795bd9c105


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79832/new/

https://reviews.llvm.org/D79832