[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 12:32:53 PDT 2020


DavidTruby added a comment.

> Anyway, why not modify DIE by appending llvm_unreachable after the call to Fortran::common::die?

This was originally the approach taken by Kiran from AMD in this patch: https://github.com/flang-compiler/f18/pull/1057
It was rejected pending the aforementioned discussion about doing things the way LLVM does them currently vs changing the LLVM policy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507





More information about the llvm-commits mailing list