[PATCH] D80516: [ConstantFolding] Constant folding for integer vector reduce intrinsics

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 11:58:45 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

> I didn't so far because I couldn't find anything to automatically handle it

For individual undef elements, I guess you could use constant folding from ConstantExpr::get().  But I guess it's not that important, practically speaking.

For the case where the entire vector is undef, you could add checks to the `if (isa<UndefValue>(Operands[0])) {` block near the top of the function.  But I guess it's not that likely to matter, anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80516/new/

https://reviews.llvm.org/D80516





More information about the llvm-commits mailing list