[PATCH] D80084: [CodeMoverUtils] Use dominator tree level to decide the direction of code motion
Whitney Tsang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 11:26:10 PDT 2020
Whitney added inline comments.
================
Comment at: llvm/include/llvm/Analysis/OrderedInstructions.h:52
+ // dominator tree if they are in different basic blocks else if the first
+ // instruction comes before the second in the same basic block
+ bool domTreeLevelBefore(const Instruction *, const Instruction *) const;
----------------
nit: sentence end with a period.
================
Comment at: llvm/lib/Analysis/OrderedInstructions.cpp:48
+bool OrderedInstructions::domTreeLevelBefore(const Instruction *InstA,
+ const Instruction *InstB) const {
+ // Use ordered basic block in case the 2 instructions are in the same basic
----------------
clang-format?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80084/new/
https://reviews.llvm.org/D80084
More information about the llvm-commits
mailing list