[PATCH] D80453: [flang] Fixes for problems with declaring procedure entities

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 10:49:57 PDT 2020


PeteSteinfeld marked an inline comment as done.
PeteSteinfeld added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:222
+  void set_interface(const ProcInterface &interface) {
+    CHECK(interface_.symbol() == nullptr && interface_.type() == nullptr);
+    interface_ = interface;
----------------
tskeith wrote:
> This could be `CHECK(!interface_.IsInterfaceSet())`.
Good suggestion.  Actually, though, I think it's `CHECK(!IsInterfaceSet()).  Stay tuned for another updates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80453/new/

https://reviews.llvm.org/D80453





More information about the llvm-commits mailing list