[PATCH] D80544: [LoopUnroll] Simplify latch/header block handling (NFC).

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 10:49:50 PDT 2020


efriedma added a comment.

Makes sense.



================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:719
 
   auto setDest = [LoopExit, ContinueOnTrue](BasicBlock *Src, BasicBlock *Dest,
                                             BasicBlock *BlockInLoop,
----------------
While you're here, can you change this so the "LoopExit" and "ContinueOnTrue" are passed in as arguments?  I think changing the meaning based on LatchIsExiting is confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80544/new/

https://reviews.llvm.org/D80544





More information about the llvm-commits mailing list