[PATCH] D70085: [AMDGPU] NFC target dependent requiresUniformRegister refactored out

[Alexander via Phabricator via llvm-commits]

alex-t marked 2 inline comments as done.
alex-t added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:31
 #include "llvm/ADT/StringRef.h"
+#include "llvm/Analysis/LegacyDivergenceAnalysis.h"
 #include "llvm/Analysis/ProfileSummaryInfo.h"
----------------
arsenm wrote:
> No reason to spread this to generic code
Why? LegacyDivergenceAnalysis.h is quite generic - not AMDGPU specific


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:712
+                           MachineFunction &MF, const Value *V) const {
+    return DA && DA->isDivergent(V);
   }
----------------
arsenm wrote:
> The DA check could have skipped the virtual call
Could you explain how it could happen? Any target with no divergent instructions have DA set to nullptr and method returns false.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70085/new/

https://reviews.llvm.org/D70085