[PATCH] D80028: [AArch64] Support expression results as immediate values in mov

[Jian Cai via Phabricator via llvm-commits]

jcai19 marked an inline comment as done.
jcai19 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:250
     AArch64MCExpr::VariantKind RefKind =
         static_cast<AArch64MCExpr::VariantKind>(Target.getRefKind());
+    if (!RefKind) {
----------------
efriedma wrote:
> I'd prefer to explicitly compute a RefKind here, as opposed to inferring that a null RefKind has some specific meaning.
We don't currently have a RefKind corresponding to zero. Should we add one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80028/new/

https://reviews.llvm.org/D80028