[PATCH] D77383: [FileCheck] Allow parenthesized expressions
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 09:44:41 PDT 2020
thopre added a comment.
In D77383#2055076 <https://reviews.llvm.org/D77383#2055076>, @arichardson wrote:
> I haven't added tests to `numeric-expressions.txt` in this revision. Do you think the unit tests are sufficient?
Yes to test end-to-end. I think 2 tests would be enough: (i) one positive and one negative test. No need to repeat all the variants of positive and negative tests that you did in the unit test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77383/new/
https://reviews.llvm.org/D77383
More information about the llvm-commits
mailing list