[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[Tim Keith via Phabricator via llvm-commits]

tskeith added a comment.

My understanding is that the behavior of `llvm_unreachable` is undefined in a Release build. If that's the case, this change makes things objectively worse for no benefit that I can see.

If it's guaranteed to abort then all that we lose it file and line number information so it's not as bad. Still, what's the benefit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507