[PATCH] D79977: [ELF][PPC64] Synthesize _savegpr[01]_{14..31} and _restgpr[01]_{14..31}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added a comment.

Thanks for the review! Will commit soon...



================
Comment at: lld/ELF/Arch/PPC64.cpp:125
+static void writeSequence(MutableArrayRef<uint32_t> buf, const char *prefix,
+                          int from, uint32_t firstInsn,
+                          ArrayRef<uint32_t> tail) {
----------------
sfertile wrote:
> nit: `from` is always 14 so we don't need it as an argument, we can just always start the loop at 14.
This is reserved for `_savevr_20` and `_restvr_20` which start from 20 instead of 14..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79977/new/

https://reviews.llvm.org/D79977