[PATCH] D80056: GlobalISel: Merge G_PTR_MASK with llvm.ptrmask intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 09:11:40 PDT 2020


arsenm closed this revision.
arsenm marked 2 inline comments as done.
arsenm added a comment.

8bc03d2168241f7b12265e9cd7e4eb7655709f34 <https://reviews.llvm.org/rG8bc03d2168241f7b12265e9cd7e4eb7655709f34>



================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:554
+/// Clear the specified bits in a pointer.
+HANDLE_TARGET_OPCODE(G_PTRMASK)
 
----------------
arsenm wrote:
> dsanders wrote:
> > Did you mean to drop the underscore? It's inconsistent with G_PTR_ADD now
> Yes. It's now consistent with the IR intrinsic
Really I'd rather rename the IR intrinsic, but it's probably not worth the hassle


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80056/new/

https://reviews.llvm.org/D80056





More information about the llvm-commits mailing list