[PATCH] D79084: [VE] Dynamic stack allocation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 08:06:20 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/Target/VE/VEFrameLowering.cpp:337
+    return FrameOffset + MF.getFrameInfo().getStackSize();
+  } else if (RegInfo->needsStackRealignment(MF) && !isFixed) {
     // If there is dynamic stack realignment, all local object
----------------
Else after return


================
Comment at: llvm/lib/Target/VE/VEFrameLowering.cpp:346
+    return FrameOffset + MF.getFrameInfo().getStackSize();
+  } else {
+    // Finally, default to using %fp.
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79084/new/

https://reviews.llvm.org/D79084





More information about the llvm-commits mailing list