[PATCH] D80545: [AMDGPU/MemOpsCluster] Let mem ops clustering logic also consider number of clustered bytes
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 08:06:19 PDT 2020
arsenm added a comment.
Missing tests
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:159-166
+ unsigned WidthA = CI.Last
+ ? !CI.Last->memoperands_empty()
+ ? CI.Last->memoperands().front()->getSize()
+ : 0
+ : 0;
+ unsigned WidthB =
+ !MI.memoperands_empty() ? MI.memoperands().front()->getSize() : 0;
----------------
It would be better to not depend on the memory operands here, but this belongs in a helper function some kind of not (and this can also sink down to the use)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80545/new/
https://reviews.llvm.org/D80545
More information about the llvm-commits
mailing list