[PATCH] D80375: [mlir][Vector] Add vector contraction to outerproduct lowering

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 6 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Vector/VectorTransforms.h:98
+
+  LogicalResult match(vector::ContractionOp op) const override;
+  void rewrite(vector::ContractionOp op,
----------------
aartbik wrote:
> just curious, is the move away from matchAndRewrite in favor of match and rewrite intentional?
I've been using this for code reuse, see how matchAndRewrite below delegates to the other pattern's match method as a preprocessing filter.
Maybe in the future the better way is to use benefits but for now I kept it to the way I did it elsewhere.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80375/new/

https://reviews.llvm.org/D80375