[PATCH] D80365: [mlir][linalg] Allow promotion to use callbacks for alloc/dealloc/copies.
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 26 03:44:55 PDT 2020
nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.
Thanks Mahesh!
================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp:63
+ /// well as to copy the data into and out of these buffers.
+ Optional<AllocBufferCallbackFn> allocationFn;
+ Optional<DeallocBufferCallbackFn> deallocationFn;
----------------
Could we have `defaultAllocBufferCallback, ...` callbacks exposed, drop the optional and drop the special if/else casing in the impl?
================
Comment at: mlir/test/Dialect/Linalg/promotion_options.mlir:34
+// CHECK: dealloc %[[T20]]
\ No newline at end of file
----------------
nit: newline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80365/new/
https://reviews.llvm.org/D80365
More information about the llvm-commits
mailing list