[PATCH] D75674: [AArch64][SVE] Implement vector tuple intrinsics

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes marked an inline comment as done.
c-rhodes added a comment.

In D75674#1931136 <https://reviews.llvm.org/D75674#1931136>, @fpetrogalli wrote:

> I think that in this patch we are missing tests that check the output code in situations in which the `tuple.get` operates on tuple that are passed to the definition of the function, as in the following example:


I've added a few tests to `test/CodeGen/AArch64/sve-intrinsics-insert-extract-tuple.ll` to test this.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13529
+      if (!DCI.isBeforeLegalizeOps())
+        return SDValue();
+
----------------
efriedma wrote:
> No point to explicitly checking isBeforeLegalizeOps(); the intrinsics should be gone after that.
Doh, done!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75674/new/

https://reviews.llvm.org/D75674