[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:1
+## Test that yaml2obj emits .debug_str section.
+
----------------
jhenderson wrote:
> jhenderson wrote:
> > In addition to the test cases in this file already, you need the following, I think:
> > 
> > a) Size is explicitly specified.
> > b) Both Size and DWARF->debug_str are specified
> > c) Both Content and DWARF->debug_str are specified
> > d) All properties that can be overridden by the section header (e.g. EntSize, Flags etc) when DWARF->debug_str is used.
> > e) The default values of Flags, EntSize etc when DWARF->debug_str is not used.
> > f) All properties that can be overridden by the section header (e.g. EntSize, Flags etc) when DWARF->debug_str is not used.
> > g) Something show that `assignSectionAddresses` is called.
> >  g) Something show that assignSectionAddresses is called.
> 
> I'm not sure I see which test case demonstrates this?
The default sh_addr is 0x0000 for .debug_str. Test (f) shows that it's overridden to be 0x2020.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203