[PATCH] D80477: [LoopUnroll] Support loop with multi exiting blocks

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

The patch doesn't apply cleanly to trunk. Could you update?

Could you summarize which restrictions remain?



================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:307-310
   // The current loop unroll pass can unroll loops with a single latch or header
   // that's a conditional branch exiting the loop.
   // FIXME: The implementation can be extended to work with more complicated
   // cases, e.g. loops with multiple latches.
----------------
Doesn't this need to be updated?


================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:339-340
   }
+  LLVM_DEBUG(dbgs() << "  Exiting Block = " << BI->getParent()->getName()
+                    << "\n");
 
----------------
If this supports any number of exits, why the need to find a special one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80477/new/

https://reviews.llvm.org/D80477